Description:
hi,
in download.php getimagesize() never works as the path is wrong.
the path should be set as in readfile few lines later.
Component:
Other
ArrowChat Version:
2.1.x
4 Posts
Customer
4 Posts
4 Posts
in general, the entire code of this function isn't very efficient.
- it iterates all files in the uploads directory looking for a file with the same base name... there could be thousands of files in that directory.
- also, the loop doesn't break when the file is found.
and in "more general", the entire code of arrowchat is really old and outdated. it might be a good idea to go open source and sell professional services.
take a look for example http://red5.org/ as they have a basic free edition and a pro edition.
in exchange you'll get a lot of free updated and improvements to your code.
be glad to hear your thoughts about it.
10x!
Roey
- it iterates all files in the uploads directory looking for a file with the same base name... there could be thousands of files in that directory.
- also, the loop doesn't break when the file is found.
and in "more general", the entire code of arrowchat is really old and outdated. it might be a good idea to go open source and sell professional services.
take a look for example http://red5.org/ as they have a basic free edition and a pro edition.
in exchange you'll get a lot of free updated and improvements to your code.
be glad to hear your thoughts about it.
10x!
Roey
Customer
2329 Posts
2329 Posts
Status Change
Changed ticket status from "Pending" to "Fix completed"
Action performed by Jason » 09 Jan 2020, 16:42
Status Change
Changed ticket status from "New" to "Pending"
Action performed by Jason » 18 Oct 2018, 15:22
